fix: persist preferences to localStorage - #98
Open
interview35 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Preferences page at
/settings/preferencesshowed a "Preferences saved locally (mock)" toast when clicking Save, but never actually persisted anything. All settings (density, table row height, line numbers, notifications, auto-save) were lost on every page refresh.What this PR does
useStatecalls into a singlePreferencesDataobject managed by oneuseStateloadPreferences()which reads fromlocalStorageunder the keyfaros.preferences, with a try-catch fallback to defaults if the stored data is corruptedloadPreferences()so preferences survive page refresheshandleSaveto serialize the preferences object tolocalStoragebefore showing the toastupdatePrefhelper to keep the setter calls clean and type-safeFile changed
frontend/src/pages/Settings/Preferences.tsx— no other files touched.Verification
prefsstateloadPreferencesmerges with defaults so adding new preference fields later won't crash on old stored datahandleSavetry-catch handleslocalStoragebeing unavailable (private browsing, quota exceeded)useTheme's own persistence mechanism — this PR only covers the five preferences that had no persistence at all